drpmma commented on code in PR #6623:
URL: https://github.com/apache/rocketmq/pull/6623#discussion_r1174728921
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java:
##########
@@ -402,9 +402,14 @@ private boolean checkQueueOk(PopCheckPointWrapper
pointWrapper) {
* @param nextBeginOffset
* @return
*/
- public void addCkJustOffset(PopCheckPoint point, int reviveQueueId, long
reviveQueueOffset, long nextBeginOffset) {
+ public boolean addCkJustOffset(PopCheckPoint point, int reviveQueueId,
long reviveQueueOffset, long nextBeginOffset) {
PopCheckPointWrapper pointWrapper = new
PopCheckPointWrapper(reviveQueueId, reviveQueueOffset, point, nextBeginOffset,
true);
+ if (this.counter.get() >
brokerController.getBrokerConfig().getPopCkMaxBufferSize()) {
Review Comment:
The
The `addCkJustOffset` will only be invoked when add ck to buffer failed.
So this condition will always be true and return false.
See addCk
https://github.com/apache/rocketmq/blob/8410785ef9d0bd2d2387bb5a706d84a4971356be/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java#L447-L467
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java:
##########
@@ -402,9 +402,14 @@ private boolean checkQueueOk(PopCheckPointWrapper
pointWrapper) {
* @param nextBeginOffset
* @return
*/
- public void addCkJustOffset(PopCheckPoint point, int reviveQueueId, long
reviveQueueOffset, long nextBeginOffset) {
+ public boolean addCkJustOffset(PopCheckPoint point, int reviveQueueId,
long reviveQueueOffset, long nextBeginOffset) {
PopCheckPointWrapper pointWrapper = new
PopCheckPointWrapper(reviveQueueId, reviveQueueOffset, point, nextBeginOffset,
true);
+ if (this.counter.get() >
brokerController.getBrokerConfig().getPopCkMaxBufferSize()) {
Review Comment:
The `addCkJustOffset` will only be invoked when add ck to buffer failed.
So this condition will always be true and return false.
See addCk
https://github.com/apache/rocketmq/blob/8410785ef9d0bd2d2387bb5a706d84a4971356be/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java#L447-L467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
