ni-ze commented on code in PR #81:
URL:
https://github.com/apache/rocketmq-schema-registry/pull/81#discussion_r1175936083
##########
common/src/main/java/org/apache/rocketmq/schema/registry/common/storage/StorageService.java:
##########
@@ -95,4 +97,8 @@ default List<String>
listSubjectsByTenant(StorageServiceContext storageServiceCo
default List<String> listTenants(StorageServiceContext storageService,
QualifiedName name) {
throw new UnsupportedOperationException(ERROR_MESSAGE_DEFAULT);
}
+
+ @Override
+ default void close() throws IOException {
+ }
Review Comment:
I think the default keywords before all method in this class is unnecessary.
can you remove them? DefaultStorageServiceImpl class is never used, and can be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
