ShadowySpirits commented on code in PR #6649:
URL: https://github.com/apache/rocketmq/pull/6649#discussion_r1176423754
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java:
##########
@@ -99,6 +99,11 @@ public boolean viaTieredStorage(String topic, int queueId,
long offset) {
public boolean viaTieredStorage(String topic, int queueId, long offset,
int batchSize) {
TieredMessageStoreConfig.TieredStorageLevel deepStorageLevel =
storeConfig.getTieredStorageLevel();
+
+ if
(deepStorageLevel.check(TieredMessageStoreConfig.TieredStorageLevel.FORCE)) {
Review Comment:
We should add a comment for the `FORCE` level. It will force
`viaTieredStorage` retuning true, but it can not prevent falling back to the
default store when failing to fetch messages from tiered storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
