[GitHub] [rocketmq-client-go] cserwen commented on a diff in pull request #1001: fix wrong add for set when tags are set

Thu, 27 Apr 2023 03:12:29 -0700 


cserwen commented on code in PR #1001:
URL: 
https://github.com/apache/rocketmq-client-go/pull/1001#discussion_r1178937746


##########
internal/model.go:
##########
@@ -73,15 +73,15 @@ func (sd *SubscriptionData) Clone() *SubscriptionData {
 
        if sd.Tags.Items() != nil {
                cloned.Tags = utils.NewSet()
-               for _, value := range sd.Tags.Items() {
-                       cloned.Tags.Add(value)
+               for key, value := range sd.Tags.Items() {
+                       cloned.Tags.AddKV(key, value.UniqueID())

Review Comment:
   `Key` is the real tag.
   
![image](https://user-images.githubusercontent.com/46882838/234832061-9ee27e80-387b-41e3-ae2a-2a580af64fb2.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to