complone commented on code in PR #94:
URL:
https://github.com/apache/rocketmq-eventbridge/pull/94#discussion_r1180346807
##########
adapter/runtimer/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtimer/Runtimer.java:
##########
@@ -75,9 +82,23 @@ public void initAndStart() {
circulatorContext.initListenerMetadata(runnerConfigObserver.getTargetRunnerConfig());
runnerConfigObserver.registerListener(circulatorContext);
runnerConfigObserver.registerListener(eventSubscriber);
- new EventBusListener(circulatorContext, eventSubscriber,
errorHandler).start();
- new EventRuleTransfer(circulatorContext, offsetManager,
errorHandler).start();
- new EventTargetPusher(circulatorContext, offsetManager,
errorHandler).start();
+ EventBusListener eventBusListener = new
EventBusListener(circulatorContext, eventSubscriber, errorHandler);
+ EventRuleTransfer eventRuleTransfer = new
EventRuleTransfer(circulatorContext, offsetManager, errorHandler);
+ EventTargetPusher eventTargetPusher = new
EventTargetPusher(circulatorContext, offsetManager, errorHandler);
+ ConcurrentHashMap<Thread, ExecutorService> threadThreadPoolExecutorMap
= new ConcurrentHashMap<Thread, ExecutorService>() {
+ {
+ put(new Thread(eventBusListener,
eventBusListener.getServiceName()), Executors.newSingleThreadExecutor());
+ put(new Thread(eventRuleTransfer,
eventRuleTransfer.getServiceName()), Executors.newSingleThreadExecutor());
+ put(new Thread(eventTargetPusher,
eventTargetPusher.getServiceName()), Executors.newSingleThreadExecutor());
+ }
+ };
+ ShutdownHookThread shutdownHookThread = new ShutdownHookThread(logger,
() -> {
Review Comment:
会议补充：由于每个组件都是相互独立的。且通过PostConstruct线程独立启动。所以没有必要维护守护线程
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
