RongtongJin commented on code in PR #6666:
URL: https://github.com/apache/rocketmq/pull/6666#discussion_r1181058621
##########
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java:
##########
@@ -309,6 +310,8 @@ public void maybeExpandInSyncStateSet(final Long
slaveBrokerId, final long slave
if (slaveMaxOffset >= confirmOffset) {
final EpochEntry currentLeaderEpoch = this.epochCache.lastEntry();
if (slaveMaxOffset >= currentLeaderEpoch.getStartOffset()) {
+ LOGGER.info("The slave {} has caught up, slaveMaxOffset: {},
confirmOffset: {}, epoch: {}, startOffset: {}.",
Review Comment:
How about renaming startOffset to leader epoch startOffset?
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -710,6 +710,7 @@ public void truncateDirtyFiles(long offsetToTruncate) {
this.reputMessageService = new ConcurrentReputMessageService();
}
+ setConfirmOffset(offsetToTruncate);
Review Comment:
Before merging #6618, confirmOffset had two different values in
AutoSwitchHAService and commitlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
