RongtongJin commented on code in PR #6618:
URL: https://github.com/apache/rocketmq/pull/6618#discussion_r1181075568
##########
store/src/main/java/org/apache/rocketmq/store/StoreCheckpoint.java:
##########
@@ -53,6 +54,7 @@ public StoreCheckpoint(final String scpPath) throws
IOException {
this.logicsMsgTimestamp = this.mappedByteBuffer.getLong(8);
this.indexMsgTimestamp = this.mappedByteBuffer.getLong(16);
this.masterFlushedOffset = this.mappedByteBuffer.getLong(24);
+ this.confirmPhyOffset = this.mappedByteBuffer.getLong(32);
Review Comment:
如果是升级上来，之前没有设置过，则默认会读取到0。
在非controller模式下，不会用到该参数，因此不会有任何影响。
在controller模式下，由于confirmOffset为0，消息会重复dispatch，此时会打印“Maybe try to build
consume queue repeatedly xxx”日志，但不会真正的dispatch。
由于老版本没有持久化confirmOffset，因此没有办法避免第一次启动时重复dispatch和日志的打印，但正常启动后不会对功能有影响。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
