mxsm commented on code in PR #6680:
URL: https://github.com/apache/rocketmq/pull/6680#discussion_r1188117819
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/heartbeat/SubscriptionData.java:
##########
@@ -38,6 +38,9 @@ public class SubscriptionData implements
Comparable<SubscriptionData> {
@JSONField(serialize = false)
private String filterClassSource;
+ @JSONField(serialize = false)
+ private transient long lastUpdateTime = System.currentTimeMillis();
Review Comment:
I don’t think it’s necessary. The lastUpdateTime is generated on the server
where the Broker is located. Even if the client generates it, it will not be
serialized and sent to the Broker, so there is no problem with changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
