absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1205564274
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
But getBrokerConfig will use isEnableBatchPush, which is inconsistence. I
think maybe we need make it the same as other config name which using the
variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
