drpmma commented on code in PR #6882:
URL: https://github.com/apache/rocketmq/pull/6882#discussion_r1223948324
##########
broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java:
##########
@@ -82,7 +82,7 @@ public class ScheduleMessageService extends ConfigManager {
private DataVersion dataVersion = new DataVersion();
private boolean enableAsyncDeliver = false;
private ScheduledExecutorService handleExecutorService;
- private final ScheduledExecutorService scheduledPersistService;
+ private ScheduledExecutorService scheduledPersistService;
Review Comment:
Would it be better that keep the scheduledPersistService final and
initialize it in the contructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
