This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch 4.9.x
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/4.9.x by this push:
     new e07754f2ab Fix incorrect naming in update configuration protection
e07754f2ab is described below

commit e07754f2ab4c637e9acbc1452de03375c4867dce
Author: RongtongJin <[email protected]>
AuthorDate: Mon Jun 12 16:28:42 2023 +0800

    Fix incorrect naming in update configuration protection
---
 .../org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java  | 2 +-
 .../apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
 
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
index 0efef1b52c..e679dcafbc 100644
--- 
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
+++ 
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
@@ -581,7 +581,7 @@ public class DefaultRequestProcessor extends 
AsyncNettyRequestProcessor implemen
                 return response;
             }
 
-            if (properties.containsKey("kvConfigPath") || 
properties.containsKey("configStorePathName")) {
+            if (properties.containsKey("kvConfigPath") || 
properties.containsKey("configStorePath")) {
                 response.setCode(ResponseCode.NO_PERMISSION);
                 response.setRemark("Can not update config path");
                 return response;
diff --git 
a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java
 
b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java
index 329fe53fe1..f22031ea6e 100644
--- 
a/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java
+++ 
b/namesrv/src/test/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessorTest.java
@@ -178,7 +178,7 @@ public class DefaultRequestProcessorTest {
 
         //update disallowed value
         properties.clear();
-        properties.setProperty("configStorePathName", "test/path");
+        properties.setProperty("configStorePath", "test/path");
         
updateConfigRequest.setBody(MixAll.properties2String(properties).getBytes(StandardCharsets.UTF_8));
 
         response = defaultRequestProcessor.processRequest(null, 
updateConfigRequest);

Reply via email to