lizhanhui commented on code in PR #541:
URL: https://github.com/apache/rocketmq-clients/pull/541#discussion_r1227487017
##########
cpp/source/rocketmq/Producer.cpp:
##########
@@ -87,7 +87,8 @@ ProducerBuilder&
ProducerBuilder::withConfiguration(Configuration configuration)
}
ProducerBuilder& ProducerBuilder::withTopics(const std::vector<std::string>&
topics) {
- impl_->topicsOfInterest(topics);
+ auto topics_copy = topics;
Review Comment:
I do not see how the proposed change is superior to the original. Any reason
for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
