aaron-ai commented on code in PR #546:
URL: https://github.com/apache/rocketmq-clients/pull/546#discussion_r1230354449


##########
python/rocketmq/client.py:
##########
@@ -0,0 +1,44 @@
+from rocketmq.client_manager import ClientManager
+from rocketmq.client_id_encoder import ClientIdEncoder
+from rocketmq.client_config import ClientConfig
+from typing import Set
+from threading import Lock
+from rocketmq import logger
+import asyncio
+
+from protocol.service_pb2 import HeartbeatRequest, QueryRouteRequest
+
+class Client:
+    def __init__(self, client_config : ClientConfig, topics : Set[str]):
+        
+        self.__client_config = client_config
+        self.__cliend_id = ClientIdEncoder.generate()
+        self.__endpoints = client_config.endpoints()
+        self.__topics = topics
+        self.__topic_route_cache = {}
+
+        self.__sessions_table = {}
+        self.__sessionsLock = Lock()
+
+        self.__client_manager = ClientManager(self)
+
+    def start_up(self):
+        logger.info("Begin to start the rocketmq client, clientId=%s", 
self.__cliend_id)

Review Comment:
   use logger.info(f"{self.__client_id}") pls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to