yuz10 commented on code in PR #6918:
URL: https://github.com/apache/rocketmq/pull/6918#discussion_r1235122541
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQAdminImpl.java:
##########
@@ -410,19 +410,7 @@ public void operationComplete(ResponseFuture
responseFuture) {
for (MessageExt msgExt : qr.getMessageList()) {
if (isUniqKey) {
if (msgExt.getMsgId().equals(key)) {
-
- if (messageList.size() > 0) {
-
- if (messageList.get(0).getStoreTimestamp()
> msgExt.getStoreTimestamp()) {
-
- messageList.clear();
- messageList.add(msgExt);
- }
Review Comment:
Actually, A consumer that achieves idempotence only takes the first message,
and ignores others. So I think it's not appropriate to keep the last message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
