RongtongJin commented on code in PR #6958:
URL: https://github.com/apache/rocketmq/pull/6958#discussion_r1244819307
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java:
##########
@@ -250,6 +261,8 @@ public void run(Timeout timeout) {
*/
protected ChannelPipeline configChannel(SocketChannel ch) {
return ch.pipeline()
+ .addLast(defaultEventExecutorGroup, HA_PROXY_DECODER, new
HAProxyMessageDecoder())
+ .addLast(defaultEventExecutorGroup, HA_PROXY_HANDLER, new
HAProxyMessageHandler())
Review Comment:
Before that, a handshake handler is needed to determine whether it is
haProxyProtocol or not, and to decide whether haProxyProtocol protocol decoder
and handler are required. This ensures compatibility regardless of whether it
is haProxyProtocol or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
