HScarb opened a new issue, #7039:
URL: https://github.com/apache/rocketmq/issues/7039

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   In `ExpressionForRetryMessageFilter`, when `isRetryTopic` is true and the 
subscription type is TAG, it won't return true now and will decode message 
properties, which decreases the performance.
   
   
https://github.com/apache/rocketmq/blob/7996ec3b3f7ccea01f66951ac639b48303bbf7a6/broker/src/main/java/org/apache/rocketmq/broker/filter/ExpressionForRetryMessageFilter.java#L48-L67
   
   ### Motivation
   
   Enhance `ExpressionForRetryMessageFilter` performance. We don't need to 
decode message properties when isRetryTopic is true and the subscription type 
is TAG. Because tag subscriptions will be filtered on the client side.
   
   ### Describe the Solution You'd Like
   
   Return true directly when the subscription type is TAG.
   
   ### Describe Alternatives You've Considered
   
   none
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to