lizhanhui commented on code in PR #576:
URL: https://github.com/apache/rocketmq-clients/pull/576#discussion_r1273259283
##########
rust/src/client.rs:
##########
@@ -534,7 +576,7 @@ impl Client {
) -> Result<Vec<Message>, ClientError> {
let request = ReceiveMessageRequest {
group: Some(Resource {
- name: self.option.group.to_string(),
+ name: self.option.group.as_ref().unwrap().to_string(),
Review Comment:
Generally, unwrap should not be used to replace error handling and
propagation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
