RongtongJin commented on code in PR #7084:
URL: https://github.com/apache/rocketmq/pull/7084#discussion_r1277004027
##########
broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java:
##########
@@ -218,8 +218,7 @@ public String encode() {
@Override
public boolean load() {
- boolean result = super.load();
- result = result && this.parseDelayLevel();
Review Comment:
If super.load() is not called, the JSON file will not be parsed, even during
startup. IMO, we can add a new method called loadWhenSyncDelayOffset, which
will not correct the delay offset when syncDelayOffset is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
