aaron-ai commented on code in PR #585: URL: https://github.com/apache/rocketmq-clients/pull/585#discussion_r1287972166
########## docs/workflow.md: ########## @@ -83,6 +83,10 @@ The receiving procedure is as follows: <img src="./artwork/message_consumption_in_push_consumer_non_FIFO.png" width="50%"> </div> +In PushConsumer, we provide retry policies for Ack/ChangeInvisibleTime to ensure the reliability of message processing. + +When calling ackMessage or changeInvisibleDuration methods, if receiving a non-OK response code, we will log the error and retry later. We will retry the method with an increasing attempt value until it succeeds. If receiving an INVALID_RECEIPT_HANDLE response code, we will not retry and directly return the exception to the caller. Review Comment: Normally, we do not use CamelCase for non-variable word combinations except for some special cases like TensorFlow or JavaScript? However, if such word combinations represent variables, it is advisable to enclose them in backticks (`). For example: - PushConsumer -> push consumer - ChangeInvisibleTime -> change invisible time - INVALID_RECEIPT_HANDLE -> `INVALID_RECEIPT_HANDLE` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
