[rocketmq] branch develop updated: [ISSUE #7146] Log output error needs to be corrected (#7147)

[lizhimin]

This is an automated email from the ASF dual-hosted git repository.

lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new bcba5a8e62 [ISSUE #7146] Log output error needs to be corrected (#7147)
bcba5a8e62 is described below

commit bcba5a8e628e35086c699852388990ba8a4bdcf8
Author: rongtong <jinrongto...@163.com>
AuthorDate: Thu Aug 10 10:19:34 2023 +0800

    [ISSUE #7146] Log output error needs to be corrected (#7147)
---
 .../main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java  | 8 ++++----
 .../java/org/apache/rocketmq/example/quickstart/Consumer.java     | 3 ++-
 .../java/org/apache/rocketmq/example/quickstart/Producer.java     | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java 
b/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
index 1793a83c05..ae81e8b11d 100644
--- a/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
+++ b/broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java
@@ -654,9 +654,9 @@ public class BrokerOuterAPI {
                     try {
                         RemotingCommand response = 
BrokerOuterAPI.this.remotingClient.invokeSync(namesrvAddr, request, 
timeoutMills);
                         assert response != null;
-                        LOGGER.info("Register single topic %s to broker %s 
with response code %s", topic, brokerName, response.getCode());
+                        LOGGER.info("Register single topic {} to broker {} 
with response code {}", topic, brokerName, response.getCode());
                     } catch (Exception e) {
-                        LOGGER.warn(String.format("Register single topic %s to 
broker %s exception", topic, brokerName), e);
+                        LOGGER.warn("Register single topic {} to broker {} 
exception", topic, brokerName, e);
                     } finally {
                         countDownLatch.countDown();
                     }
@@ -722,10 +722,10 @@ public class BrokerOuterAPI {
                                 default:
                                     break;
                             }
-                            LOGGER.warn("Query data version from name server 
{} OK, changed {}, broker {},name server {}", namesrvAddr, changed, 
topicConfigWrapper.getDataVersion(), nameServerDataVersion == null ? "" : 
nameServerDataVersion);
+                            LOGGER.warn("Query data version from name server 
{} OK, changed {}, broker {}, name server {}", namesrvAddr, changed, 
topicConfigWrapper.getDataVersion(), nameServerDataVersion == null ? "" : 
nameServerDataVersion);
                         } catch (Exception e) {
                             changedList.add(Boolean.TRUE);
-                            LOGGER.error("Query data version from name server 
{}  Exception, {}", namesrvAddr, e);
+                            LOGGER.error("Query data version from name server 
{} exception", namesrvAddr, e);
                         } finally {
                             countDownLatch.countDown();
                         }
diff --git 
a/example/src/main/java/org/apache/rocketmq/example/quickstart/Consumer.java 
b/example/src/main/java/org/apache/rocketmq/example/quickstart/Consumer.java
index 41c9eedd9c..3a101bf664 100644
--- a/example/src/main/java/org/apache/rocketmq/example/quickstart/Consumer.java
+++ b/example/src/main/java/org/apache/rocketmq/example/quickstart/Consumer.java
@@ -49,7 +49,8 @@ public class Consumer {
          * }
          * </pre>
          */
-        consumer.setNamesrvAddr(DEFAULT_NAMESRVADDR);
+        // Uncomment the following line while debugging, namesrvAddr should be 
set to your local address
+        // consumer.setNamesrvAddr(DEFAULT_NAMESRVADDR);
 
         /*
          * Specify where to start in case the specific consumer group is a 
brand-new one.
diff --git 
a/example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java 
b/example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java
index 2c67e463e6..aac2950300 100644
--- a/example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java
+++ b/example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java
@@ -54,7 +54,7 @@ public class Producer {
          * </pre>
          */
         // Uncomment the following line while debugging, namesrvAddr should be 
set to your local address
-        producer.setNamesrvAddr(DEFAULT_NAMESRVADDR);
+        // producer.setNamesrvAddr(DEFAULT_NAMESRVADDR);
 
         /*
          * Launch the instance.