This is an automated email from the ASF dual-hosted git repository.

kaili pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 2b93e1e32 Update mqbroker to use runbroker.sh instead of runserver.sh 
when use --enable-proxy (#7150)
2b93e1e32 is described below

commit 2b93e1e32fd458d9df2091e89ea259ddd4d54061
Author: iamgd67 <[email protected]>
AuthorDate: Thu Aug 17 15:31:14 2023 +0800

    Update mqbroker to use runbroker.sh instead of runserver.sh when use 
--enable-proxy (#7150)
    
    Update mqbroker to use runbroker.sh instead of runserver.sh when enabling 
`--enable-proxy`
    this allow JVM `heap` and `gc` configuration using broker's settings 
instead of other common serverices'(proxy,namenode, etc).
    our main purpose, like the filename `mqbroker` suggest, is to start broker 
(which embeds a proxy), so use broker's config is reasonable
    
    chinese version
    
mqbroker的--enable-proxy选项是启动内嵌了proxy的broker,而不是内嵌broker的proxy,而且broker的工作量和重要程度大于proxy,所以使用broker的gc和heap配置更合适
---
 distribution/bin/mqbroker | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/distribution/bin/mqbroker b/distribution/bin/mqbroker
index 3758ed597..35eb93c44 100644
--- a/distribution/bin/mqbroker
+++ b/distribution/bin/mqbroker
@@ -68,11 +68,11 @@ if [ "$enable_proxy" = true ]; then
   if [ "$broker_config" != "" ]; then
       args_for_proxy=${args_for_proxy}" -bc "${broker_config}
   fi
-  sh ${ROCKETMQ_HOME}/bin/runserver.sh 
-Drmq.logback.configurationFile=$ROCKETMQ_HOME/conf/rmq.proxy.logback.xml 
org.apache.rocketmq.proxy.ProxyStartup ${args_for_proxy}
+  sh ${ROCKETMQ_HOME}/bin/runbroker.sh 
-Drmq.logback.configurationFile=$ROCKETMQ_HOME/conf/rmq.proxy.logback.xml 
org.apache.rocketmq.proxy.ProxyStartup ${args_for_proxy}
 else
   args_for_broker=$other_args
   if [ "$broker_config" != "" ]; then
       args_for_broker=${args_for_broker}" -c "${broker_config}
   fi
   sh ${ROCKETMQ_HOME}/bin/runbroker.sh 
-Drmq.logback.configurationFile=$ROCKETMQ_HOME/conf/rmq.broker.logback.xml 
org.apache.rocketmq.broker.BrokerStartup ${args_for_broker}
-fi
\ No newline at end of file
+fi

Reply via email to