Tomilla commented on PR #1087: URL: https://github.com/apache/rocketmq-client-go/pull/1087#issuecomment-1684997687
Compare this to @Slideeeee's PR (https://github.com/apache/rocketmq-client-go/pull/1006), which tried to import a go-version JavaScript interpreter into the project, but this was only used in very small cases (json loading), so it is overkill for our limited needs. My solution is green and doesn't introduce any 3rd party heavyweight modules. furthermore, since it all uses native syntax or built-in libraries, it is better performance than adding a VM layer. Related to https://github.com/apache/rocketmq-client-go/issues/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
