HScarb commented on code in PR #7209:
URL: https://github.com/apache/rocketmq/pull/7209#discussion_r1302362122
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -542,16 +543,28 @@ private synchronized RemotingCommand
deleteTopic(ChannelHandlerContext ctx,
}
}
-
this.brokerController.getTopicConfigManager().deleteTopicConfig(requestHeader.getTopic());
-
this.brokerController.getTopicQueueMappingManager().delete(requestHeader.getTopic());
-
this.brokerController.getConsumerOffsetManager().cleanOffsetByTopic(requestHeader.getTopic());
-
this.brokerController.getPopInflightMessageCounter().clearInFlightMessageNumByTopicName(requestHeader.getTopic());
-
this.brokerController.getMessageStore().deleteTopics(Sets.newHashSet(requestHeader.getTopic()));
+ final Set<String> groups =
this.brokerController.getConsumerOffsetManager().whichGroupByTopic(topic);
+ // delete pop retry topics first
Review Comment:
ok, I’ve updated the code
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -542,16 +543,28 @@ private synchronized RemotingCommand
deleteTopic(ChannelHandlerContext ctx,
}
}
-
this.brokerController.getTopicConfigManager().deleteTopicConfig(requestHeader.getTopic());
-
this.brokerController.getTopicQueueMappingManager().delete(requestHeader.getTopic());
-
this.brokerController.getConsumerOffsetManager().cleanOffsetByTopic(requestHeader.getTopic());
-
this.brokerController.getPopInflightMessageCounter().clearInFlightMessageNumByTopicName(requestHeader.getTopic());
-
this.brokerController.getMessageStore().deleteTopics(Sets.newHashSet(requestHeader.getTopic()));
+ final Set<String> groups =
this.brokerController.getConsumerOffsetManager().whichGroupByTopic(topic);
+ // delete pop retry topics first
Review Comment:
ok, I’ve updated the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
