2011shenlin commented on code in PR #149:
URL:
https://github.com/apache/rocketmq-eventbridge/pull/149#discussion_r1311042543
##########
domain/src/main/java/org/apache/rocketmq/eventbridge/domain/common/exception/EventBridgeErrorCode.java:
##########
@@ -134,7 +135,10 @@ public enum EventBridgeErrorCode implements BaseErrorCode {
ClientSecretLengthExceed(409, "ClientSecretLengthExceed", "ClientSecret
length cannot exceed 127!"),
AuthorizationEndpointLengthExceed(409,
"AuthorizationEndpointLengthExceed", "Authorization endpoint length cannot
exceed 127!"),
NetworkParametersIsEmpty(409, "NetworkParametersIsEmpty", "Network
required parameter is empty!"),
- RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter
Invalid!");
+ RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter
Invalid!"),
+ CreatePrivateNetworkFailed(409, "CreatePrivateNetworkFailed", "Create
private network failed!"),
+ DeletePrivateNetworkFailed(409, "DeletePrivateNetworkFailed", "Delete
private network failed!"),
+ GetTotalQuotaFailed(409, "GetTotalQuotaFailed", "Query total quota
failed!");
Review Comment:
这几个参数异常信息提示不够明确
##########
domain/src/main/java/org/apache/rocketmq/eventbridge/domain/common/exception/EventBridgeErrorCode.java:
##########
@@ -134,7 +135,10 @@ public enum EventBridgeErrorCode implements BaseErrorCode {
ClientSecretLengthExceed(409, "ClientSecretLengthExceed", "ClientSecret
length cannot exceed 127!"),
AuthorizationEndpointLengthExceed(409,
"AuthorizationEndpointLengthExceed", "Authorization endpoint length cannot
exceed 127!"),
NetworkParametersIsEmpty(409, "NetworkParametersIsEmpty", "Network
required parameter is empty!"),
- RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter
Invalid!");
+ RequestParameterInvalid(409, "RequestParameterInvalid", "Request parameter
Invalid!"),
+ CreatePrivateNetworkFailed(409, "CreatePrivateNetworkFailed", "Create
private network failed!"),
+ DeletePrivateNetworkFailed(409, "DeletePrivateNetworkFailed", "Delete
private network failed!"),
+ GetTotalQuotaFailed(409, "GetTotalQuotaFailed", "Query total quota
failed!");
Review Comment:
这几个参数异常信息提示不够明确
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
