joeCarf commented on code in PR #7359:
URL: https://github.com/apache/rocketmq/pull/7359#discussion_r1326717796


##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/PullRequestHoldService.java:
##########
@@ -54,6 +56,11 @@ public void suspendPullRequest(final String topic, final int 
queueId, final Pull
 
         pullRequest.getRequestCommand().setSuspended(true);
         mpr.addPullRequest(pullRequest);
+        // check the last notify maxOffset

Review Comment:
   if the pull request been put in the `pullRequestTable`, will it be processed 
repeated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to