RapperCL opened a new issue, #7366:
URL: https://github.com/apache/rocketmq/issues/7366

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   1. Judgment optimization 
   It is better to compare the length of the remark and extInfo with the 
current remaining readable length rather than directly with the length of the 
header.
   
![1694880196380](https://github.com/apache/rocketmq/assets/44110731/caf110b6-e65d-4a26-9280-a71167bed99a)
   
   2 Parameter Naming Optimization
   This should not be named headerBuffer, as the byteBuffer passed in here also 
contains body data.
   
![1694880554905](https://github.com/apache/rocketmq/assets/44110731/02ed866a-4a06-43f0-a154-39f90ae69909)
   
   
   
   ### Motivation
   
   By comparison, it can be more accurate and early to determine whether the 
data in byteBuffer is normal
   
   ### Describe the Solution You'd Like
   
   It is better to compare the length of the remark and extInfo with the 
current remaining readable length rather than directly with the length of the 
header.
   
   ### Describe Alternatives You've Considered
   
   It is better to compare the length of the remark and extInfo with the 
current remaining readable length rather than directly with the length of the 
header.
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to