dingshuangxi888 commented on code in PR #7367:
URL: https://github.com/apache/rocketmq/pull/7367#discussion_r1335599653
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RocketMQSerializable.java:
##########
@@ -202,29 +202,33 @@ private static int calTotalLen(int remark, int ext) {
return length;
}
- public static RemotingCommand rocketMQProtocolDecode(final ByteBuf
headerBuffer,
+ public static RemotingCommand rocketMQProtocolDecode(final ByteBuf
byteBuffer,
Review Comment:
个人认为原来的命名是跟业务比较相关，如果是通用的工具方法的话，命名byteBuffer没有任何问题。但是这个方法应该就是操作header，原来的命名会更具可读性
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RocketMQSerializable.java:
##########
@@ -202,29 +202,33 @@ private static int calTotalLen(int remark, int ext) {
return length;
}
- public static RemotingCommand rocketMQProtocolDecode(final ByteBuf
headerBuffer,
+ public static RemotingCommand rocketMQProtocolDecode(final ByteBuf
byteBuffer,
Review Comment:
个人认为原来的命名是跟业务比较相关，如果是通用的工具方法的话，命名byteBuffer没有任何问题。但是这个方法应该就是操作header，原来的命名会更具可读性
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
