0daypwn commented on PR #1052: URL: https://github.com/apache/rocketmq-client-go/pull/1052#issuecomment-1738724280
https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/consumer/consumer.go#L296-L306 谁写入channel，谁负责关闭 是个好习惯 在已经有 close(pq.closeChan) 之后，再 close(pq.msgCh) 这个操作完全是多余的，关闭还会导致上述写入的风险。 在 close(pq.closeChan) 之后，只要不 close(pq.msgCh)， pq.putMessage 和 pq.getMessage 即使select到 msgCh 也不会有影响。 pq.putMessage 和 pq.getMessage 之后是一定可以return的。 因此我认为可以只去掉 close(pq.msgCh) 这部分即可 @cserwen 另外 consumer/consumer.go 这部分是基类 修改需要考虑 consumer/push_consumer.go consuemr/pull_consumer.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
