yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345153126
##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -24,7 +24,9 @@ public class ControllerConfig {
private String rocketmqHome =
System.getProperty(MixAll.ROCKETMQ_HOME_PROPERTY,
System.getenv(MixAll.ROCKETMQ_HOME_ENV));
private String configStorePath = System.getProperty("user.home") +
File.separator + "controller" + File.separator + "controller.properties";
-
+ public static final String DLEDGER_CONTROLLER = "DLedger";
Review Comment:
Using enum is indeed more elegant, but I think using string constants here
is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
