joeCarf commented on code in PR #7502:
URL: https://github.com/apache/rocketmq/pull/7502#discussion_r1372587651
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -440,6 +440,13 @@ private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext
return response;
}
+ if
(topicConfig.equals(this.brokerController.getTopicConfigManager().getTopicConfigTable().get(topic)))
{
+ LOGGER.info("Broker receive request to update or create topic={},
but topic exists, so idempotent, caller address={}",
Review Comment:
log内容改成“topic对应的topicConfig没有发生变化“而不是”topic已存在“会不会语义更明确呢～
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -440,6 +440,13 @@ private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext
return response;
}
+ if
(topicConfig.equals(this.brokerController.getTopicConfigManager().getTopicConfigTable().get(topic)))
{
+ LOGGER.info("Broker receive request to update or create topic={},
but topic exists, so idempotent, caller address={}",
Review Comment:
log内容改成“topic对应的topicConfig没有发生变化“而不是”topic已存在“会不会语义更明确呢～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
