drivebyer commented on code in PR #186:
URL: https://github.com/apache/rocketmq-operator/pull/186#discussion_r1415303793
##########
pkg/controller/broker/broker_controller.go:
##########
@@ -398,6 +402,15 @@ func getBrokerName(broker *rocketmqv1alpha1.Broker,
brokerGroupIndex int) string
return broker.Name + "-" + strconv.Itoa(brokerGroupIndex)
}
+func isReady(po corev1.Pod) bool {
+ for _, cond := range po.Status.Conditions {
+ if cond.Type == corev1.PodReady {
Review Comment:
Yes. I means we should wait pod to be ready, then execute follow reconcile
code(https://github.com/apache/rocketmq-operator/blob/a8665716c8028741ec106814798e39fe07e6dcaa/pkg/controller/broker/broker_controller.go#L277-L343)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
