lizhanhui commented on code in PR #646:
URL: https://github.com/apache/rocketmq-clients/pull/646#discussion_r1415570722
##########
rust/src/session.rs:
##########
@@ -566,8 +566,9 @@ impl SessionManager {
)
.await?;
session.start(settings, telemetry_command_tx).await?;
- session_map.insert(endpoint_url.clone(), session.clone());
- Ok(session)
+ let cloned_session = session.clone();
Review Comment:
It looks like the clone differs from the original, which is somewhat weired
and should be avoided, see
https://doc.rust-lang.org/stable/std/clone/trait.Clone.html#how-can-i-implement-clone
We need to modify `Session` to make itself and its clones are idential.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
