lizhanhui commented on code in PR #658:
URL: https://github.com/apache/rocketmq-clients/pull/658#discussion_r1437674136
##########
rust/src/model/message.rs:
##########
@@ -21,9 +21,27 @@ use std::collections::HashMap;
use crate::error::{ClientError, ErrorKind};
use crate::model::common::Endpoints;
+use crate::model::message::MessageType::{DELAY, FIFO, NORMAL, TRANSACTION};
use crate::model::message_id::UNIQ_ID_GENERATOR;
use crate::pb;
+pub enum MessageType {
+ NORMAL = 1,
+ FIFO = 2,
+ DELAY = 3,
+ TRANSACTION = 4,
+}
+
+fn transform_to_pb_message_type(message_type: &MessageType) -> i32 {
Review Comment:
IMO, it would be better to implement From trait for &MessageType than
offering a free function:
```
impl From<&MessageType> for i32 {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
