guyinyou commented on code in PR #7734:
URL: https://github.com/apache/rocketmq/pull/7734#discussion_r1445683893
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -555,12 +556,12 @@ private synchronized RemotingCommand
deleteTopic(ChannelHandlerContext ctx,
// delete pop retry topics first
try {
for (String group : groups) {
- final String popRetryTopic =
KeyBuilder.buildPopRetryTopic(topic, group);
+ final String popRetryTopic =
KeyBuilder.buildPopRetryTopic(topic, group,
brokerController.getBrokerConfig().isEnableRetryTopicV2());
Review Comment:
这里感觉可以直接传true进去，和修改前的逻辑保持一致，同时删除v1和v2的retryTopic。不然在开关关闭的情况下可能v2就不会删除留下脏数据
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
