joeCarf commented on code in PR #7862:
URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1510280013
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -134,14 +136,14 @@ public
ProxyAndTlsProtocolHandler(GrpcHttp2ConnectionHandler grpcHandler) {
protected void decode(ChannelHandlerContext ctx, ByteBuf in,
List<Object> out) {
try {
ProtocolDetectionResult<HAProxyProtocolVersion> ha =
HAProxyMessageDecoder.detectProtocol(
- in);
+ in);
if (ha.state() == ProtocolDetectionState.NEEDS_MORE_DATA) {
return;
}
if (ha.state() == ProtocolDetectionState.DETECTED) {
ctx.pipeline().addAfter(ctx.name(), HA_PROXY_DECODER, new
HAProxyMessageDecoder())
- .addAfter(HA_PROXY_DECODER, HA_PROXY_HANDLER, new
HAProxyMessageHandler())
Review Comment:
格式化改动有点多
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -134,14 +136,14 @@ public
ProxyAndTlsProtocolHandler(GrpcHttp2ConnectionHandler grpcHandler) {
protected void decode(ChannelHandlerContext ctx, ByteBuf in,
List<Object> out) {
try {
ProtocolDetectionResult<HAProxyProtocolVersion> ha =
HAProxyMessageDecoder.detectProtocol(
- in);
+ in);
if (ha.state() == ProtocolDetectionState.NEEDS_MORE_DATA) {
return;
}
if (ha.state() == ProtocolDetectionState.DETECTED) {
ctx.pipeline().addAfter(ctx.name(), HA_PROXY_DECODER, new
HAProxyMessageDecoder())
- .addAfter(HA_PROXY_DECODER, HA_PROXY_HANDLER, new
HAProxyMessageHandler())
Review Comment:
这部分是不是误格式化了 有点干扰review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
