lizhimins commented on code in PR #7895:
URL: https://github.com/apache/rocketmq/pull/7895#discussion_r1528225293
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -187,16 +187,16 @@ public void processMessageReceived(ChannelHandlerContext
ctx, RemotingCommand ms
}
protected void doBeforeRpcHooks(String addr, RemotingCommand request) {
- if (rpcHooks.size() > 0) {
- for (RPCHook rpcHook : rpcHooks) {
+ if (RPC_HOOKS.size() > 0) {
+ for (RPCHook rpcHook : RPC_HOOKS) {
rpcHook.doBeforeRequest(addr, request);
}
}
}
- public void doAfterRpcHooks(String addr, RemotingCommand request,
RemotingCommand response) {
- if (rpcHooks.size() > 0) {
- for (RPCHook rpcHook : rpcHooks) {
+ public static void doAfterRpcHooks(String addr, RemotingCommand request,
RemotingCommand response) {
Review Comment:
这里怪怪的，doBeforeRpcHooks 不是 static 的但是 doAfterRpcHooks 是 static 的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
