RongtongJin commented on code in PR #8024:
URL: https://github.com/apache/rocketmq/pull/8024#discussion_r1566860490
##########
client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumer.java:
##########
@@ -150,6 +149,23 @@ void pullBlockIfNotFound(final MessageQueue mq, final
String subExpression, fina
final int maxNums, final PullCallback pullCallback) throws
MQClientException, RemotingException,
InterruptedException;
+ /**
+ * Pulling the messages through callback function,if no message
arrival,blocking. Support message selection
+ */
+ void pullBlockIfNotFoundWithMessageSelector(final MessageQueue mq, final
MessageSelector selector,
Review Comment:
The main issue is that when the second parameter is null, it's impossible to
distinguish between the two methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
