(rocketmq) branch develop updated: [ISSUE #8118] Remove redundant mod in client (#8119)

[lizhimin]

This is an automated email from the ASF dual-hosted git repository.

lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 502e2d798e [ISSUE #8118] Remove redundant mod in client (#8119)
502e2d798e is described below

commit 502e2d798e57fd4f40d16a90c44679af5ee7f986
Author: hiyo <77013030+miles-...@users.noreply.github.com>
AuthorDate: Tue May 14 14:45:29 2024 +0800

    [ISSUE #8118] Remove redundant mod in client (#8119)
---
 .../client/consumer/rebalance/AllocateMessageQueueAveragely.java       | 2 +-
 .../java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
 
b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
index 75e5d1c218..6f63a6fc60 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely.java
@@ -42,7 +42,7 @@ public class AllocateMessageQueueAveragely extends 
AbstractAllocateMessageQueueS
         int startIndex = (mod > 0 && index < mod) ? index * averageSize : 
index * averageSize + mod;
         int range = Math.min(averageSize, mqAll.size() - startIndex);
         for (int i = 0; i < range; i++) {
-            result.add(mqAll.get((startIndex + i) % mqAll.size()));
+            result.add(mqAll.get(startIndex + i));
         }
         return result;
     }
diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
index 227f3346d0..f964869ac2 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
@@ -1222,8 +1222,7 @@ public class MQClientInstance {
         if (topicRouteData != null) {
             List<BrokerData> brokers = topicRouteData.getBrokerDatas();
             if (!brokers.isEmpty()) {
-                int index = random.nextInt(brokers.size());
-                BrokerData bd = brokers.get(index % brokers.size());
+                BrokerData bd = brokers.get(random.nextInt(brokers.size()));
                 return bd.selectBrokerAddr();
             }
         }