(rocketmq) branch develop updated: [ISSUE #8136] Replace with createProcessQueue and remove createProcessQueue(topic) in client (#8139)

[jinrongtong]

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 2fdafd232a [ISSUE #8136] Replace with createProcessQueue and remove 
createProcessQueue(topic) in client (#8139)
2fdafd232a is described below

commit 2fdafd232a45ffd4a72239782248e2d1a91d6abc
Author: hiyo <77013030+miles-...@users.noreply.github.com>
AuthorDate: Wed May 15 10:01:21 2024 +0800

    [ISSUE #8136] Replace with createProcessQueue and remove 
createProcessQueue(topic) in client (#8139)
---
 .../java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java | 4 +---
 .../apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java  | 3 ---
 .../org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java  | 4 ----
 .../org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java  | 5 -----
 4 files changed, 1 insertion(+), 15 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
index 53addc5f50..711df3a9f0 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
@@ -525,7 +525,7 @@ public abstract class RebalanceImpl {
                 }
 
                 this.removeDirtyOffset(mq);
-                ProcessQueue pq = createProcessQueue(topic);
+                ProcessQueue pq = createProcessQueue();
                 pq.setLocked(true);
                 long nextOffset = this.computePullFromWhere(mq);
                 if (nextOffset >= 0) {
@@ -779,8 +779,6 @@ public abstract class RebalanceImpl {
 
     public abstract PopProcessQueue createPopProcessQueue();
 
-    public abstract ProcessQueue createProcessQueue(String topicName);
-
     public void removeProcessQueue(final MessageQueue mq) {
         ProcessQueue prev = this.processQueueTable.remove(mq);
         if (prev != null) {
diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java
index 335d89b787..330772f22b 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java
@@ -177,7 +177,4 @@ public class RebalanceLitePullImpl extends RebalanceImpl {
         return null;
     }
 
-    public ProcessQueue createProcessQueue(String topicName) {
-        return createProcessQueue();
-    }
 }
diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java
index 1b5f976617..e0b682868a 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java
@@ -103,8 +103,4 @@ public class RebalancePullImpl extends RebalanceImpl {
         return null;
     }
 
-    public ProcessQueue createProcessQueue(String topicName) {
-        return createProcessQueue();
-    }
-
 }
diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java
index f28890d306..59e087c0e0 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java
@@ -288,11 +288,6 @@ public class RebalancePushImpl extends RebalanceImpl {
         return new ProcessQueue();
     }
 
-    @Override
-    public ProcessQueue createProcessQueue(String topicName) {
-        return createProcessQueue();
-    }
-
     @Override
     public PopProcessQueue createPopProcessQueue() {
         return new PopProcessQueue();