guyinyou commented on code in PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750#discussion_r1601244958
##########
nodejs/src/consumer/SimpleConsumer.ts:
##########
@@ -60,8 +60,11 @@ export class SimpleConsumer extends Consumer {
}
}
this.#awaitDuration = options.awaitDuration ?? 30000;
- this.#simpleSubscriptionSettings = new
SimpleSubscriptionSettings(this.clientId, this.endpoints,
- this.consumerGroup, this.requestTimeout, this.#awaitDuration,
this.#subscriptionExpressions);
+ if (options.namespace) {
Review Comment:
这里给namespace初始化一个空字符串，就不需要多次判空了，proxy侧会兼容空字符串的情况将其认为是默认值
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
