humkum commented on code in PR #8143:
URL: https://github.com/apache/rocketmq/pull/8143#discussion_r1601549362
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -1462,6 +1468,10 @@ private RemotingCommand
updateAndCreateSubscriptionGroup(ChannelHandlerContext c
response.setCode(ResponseCode.SUCCESS);
response.setRemark(null);
+ long endTime = System.currentTimeMillis();
+ long executionTime = endTime - startTime;
+ LOGGER.info("" + config.getGroupName() + " is " + executionTime +
"ms");
+ LOGGER.info("" + config.getGroupName() + " is " + executionTime +
"ms");
Review Comment:
Repeated line
##########
broker/src/main/java/org/apache/rocketmq/broker/filter/CommitLogDispatcherCalcBitMap.java:
##########
@@ -67,6 +67,7 @@ public void dispatch(DispatchRequest request) {
while (iterator.hasNext()) {
ConsumerFilterData filterData = iterator.next();
+
Review Comment:
No need blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
