yx9o commented on code in PR #8231:
URL: https://github.com/apache/rocketmq/pull/8231#discussion_r1622522134
##########
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java:
##########
@@ -268,7 +269,9 @@ public static PlainAccessResource parse(GeneratedMessageV3
messageV3, Authentica
}
} else if
(NotifyClientTerminationRequest.getDescriptor().getFullName().equals(rpcFullName))
{
NotifyClientTerminationRequest request =
(NotifyClientTerminationRequest) messageV3;
- accessResource.addGroupResourceAndPerm(request.getGroup(),
Permission.SUB);
+ if (StringUtils.isNotBlank(request.getGroup().getName())) {
Review Comment:
Can you consider replacing `StringUtils.isNotBlank` with
`org.apache.rocketmq.common.UtilAll#isBlank`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
