YxAc commented on code in PR #279:
URL: https://github.com/apache/rocketmq-mqtt/pull/279#discussion_r1630793092
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/infly/PushAction.java:
##########
@@ -181,6 +185,12 @@ public void write(Session session, Message message, int
mqttId, int qos, Subscri
data = MqttMessageFactory.buildPublishMessage(topicName,
message.getPayload(), qos, retained, mqttId);
break;
case MQTT_5:
+ // Server send PublishMessage flow control
+ if (qos > 0 && !channelManager.publishSendTryAcquire(channel))
{
+ logger.error("publishSendTryAcquire failed, client:{},
message:{}", clientId, message);
+ return;
+ }
Review Comment:
Yes, the retry logic will also step into the `write` function and require
the quota by flow control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
