Mrhorse99 opened a new issue, #8274: URL: https://github.com/apache/rocketmq/issues/8274
### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary The issue include some optimization for the code style and simplify some code. ### Motivation It make some changes to optimize the code a bit. ### Describe the Solution You'd Like The main optimizations are threefold: Simplify the code： <img width="474" alt="image" src="https://github.com/apache/rocketmq/assets/82942806/07c4b53e-7ece-47c3-bd84-76fa6681f9fd";> <img width="695" alt="image" src="https://github.com/apache/rocketmq/assets/82942806/0cdbfe84-2f34-403f-8a1c-e34a21447d9e";> Use the forEach function to replace the stream method in order to avoid the price on creating and destroying the stream object： <img width="896" alt="image" src="https://github.com/apache/rocketmq/assets/82942806/b1572837-f845-4f9e-a4a0-197ec725cb6f";> fix the potential npe problem： if somwhere doesn't check the file as a directory , the files may be null and the length function may cause the npe problem. <img width="616" alt="image" src="https://github.com/apache/rocketmq/assets/82942806/4fb721e1-0859-4e2c-8937-9acaa4c9f1cb";> ### Describe Alternatives You've Considered The code may be enough for the optimization ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
