Qoozm opened a new issue, #8448:
URL: https://github.com/apache/rocketmq/issues/8448

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   This is a annotation optimize about CommitLog's doAppend function
   
   ### Motivation
   
   Hi Community!
   As a newcomer, annotation is important for me to read and understand the 
code, when i was learned about store flow, i find there are some fuzzy 
annotation.
   
   
![1721975033085](https://github.com/user-attachments/assets/0e38d428-c127-46f1-af19-f4da5c16a742)
   1. There are't explain of pos init
   2. There are two problem
        1. The first 8 belong to PHYSICALOFFSET but SYSFLAG,, maybe we should 
add 8 to pos after line 1972 
        2. "11 STORETIMESTAMP" annotation should at 1977
   3. The UtilAll.crc32 function will change buffer's position index, add a 
annotation is more clear
   
   ### Describe the Solution You'd Like
   
   Here is my optimization plan.
   <img width="1717" alt="image" 
src="https://github.com/user-attachments/assets/3bd233d4-663a-42d9-a2f7-947aa558f5e8";>
   
   
   ### Describe Alternatives You've Considered
   
   no
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to