This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 9059fcddd8 [ISSUE #8519] Add test case for rocketmq acl module. (#8508)
9059fcddd8 is described below
commit 9059fcddd8f56792957c6c8ddbe71bc0815fa8eb
Author: Hard_X <[email protected]>
AuthorDate: Fri Aug 16 14:30:32 2024 +0800
[ISSUE #8519] Add test case for rocketmq acl module. (#8508)
* add AuthorizationHeaderTest
* add PlainPermissionCheckerTest
* add license header for AuthorizationHeaderTest and
PlainPermissionCheckerTest
* Update
---
.../acl/common/AuthorizationHeaderTest.java | 64 ++++++++++++++++
.../acl/plain/PlainPermissionCheckerTest.java | 88 ++++++++++++++++++++++
2 files changed, 152 insertions(+)
diff --git
a/acl/src/test/java/org/apache/rocketmq/acl/common/AuthorizationHeaderTest.java
b/acl/src/test/java/org/apache/rocketmq/acl/common/AuthorizationHeaderTest.java
new file mode 100644
index 0000000000..bb735f0a04
--- /dev/null
+++
b/acl/src/test/java/org/apache/rocketmq/acl/common/AuthorizationHeaderTest.java
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.acl.common;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.Assert;
+
+public class AuthorizationHeaderTest {
+
+ private static final String AUTH_HEADER = "Signature
Credential=1234567890/test, SignedHeaders=host, Signature=1234567890";
+ private AuthorizationHeader authorizationHeader;
+
+ @Before
+ public void setUp() throws Exception {
+ authorizationHeader = new AuthorizationHeader(AUTH_HEADER);
+ }
+
+ @Test
+ public void testGetMethod() {
+ Assert.assertEquals("Signature", authorizationHeader.getMethod());
+ }
+
+ @Test
+ public void testGetAccessKey() {
+ Assert.assertEquals("1234567890", authorizationHeader.getAccessKey());
+ }
+
+ @Test
+ public void testGetSignedHeaders() {
+ String[] expectedHeaders = {"host"};
+ Assert.assertArrayEquals(expectedHeaders,
authorizationHeader.getSignedHeaders());
+ }
+
+ @Test
+ public void testGetSignature() {
+ Assert.assertEquals("EjRWeJA=", authorizationHeader.getSignature());
+ }
+
+ @Test(expected = Exception.class)
+ public void testInvalidAuthorizationHeader() throws Exception {
+ new AuthorizationHeader("Invalid Header");
+ }
+
+ @Test(expected = Exception.class)
+ public void testMalformedAuthorizationHeader() throws Exception {
+ new AuthorizationHeader("Malformed, Header");
+ }
+
+}
diff --git
a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionCheckerTest.java
b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionCheckerTest.java
new file mode 100644
index 0000000000..4df0ea5d2d
--- /dev/null
+++
b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionCheckerTest.java
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.acl.plain;
+
+import org.apache.rocketmq.acl.common.AclException;
+import org.apache.rocketmq.acl.common.Permission;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.Assert;
+
+public class PlainPermissionCheckerTest {
+
+ private PlainPermissionChecker permissionChecker;
+
+ @Before
+ public void setUp() {
+ permissionChecker = new PlainPermissionChecker();
+ }
+
+ @Test
+ public void testCheck_withAdminPermission_shouldPass() {
+ PlainAccessResource checkedAccess = new PlainAccessResource();
+ checkedAccess.setRequestCode(Permission.SUB);
+ checkedAccess.addResourceAndPerm("topic1", Permission.PUB);
+ PlainAccessResource ownedAccess = new PlainAccessResource();
+ ownedAccess.setAccessKey("adminUser");
+ ownedAccess.setAdmin(true);
+ try {
+ permissionChecker.check(checkedAccess, ownedAccess);
+ } catch (AclException e) {
+ Assert.fail("Should not throw any exception for admin user");
+ }
+ }
+
+ @Test(expected = AclException.class)
+ public void
testCheck_withoutAdminPermissionAndNoDefaultPerm_shouldThrowAclException() {
+ PlainAccessResource checkedAccess = new PlainAccessResource();
+ checkedAccess.setRequestCode(Permission.SUB);
+ checkedAccess.addResourceAndPerm("topic1", Permission.PUB);
+ PlainAccessResource ownedAccess = new PlainAccessResource();
+ ownedAccess.setAccessKey("nonAdminUser");
+ ownedAccess.setAdmin(false);
+ permissionChecker.check(checkedAccess, ownedAccess);
+ }
+
+ @Test
+ public void testCheck_withDefaultPermissions_shouldPass() {
+ PlainAccessResource checkedAccess = new PlainAccessResource();
+ checkedAccess.setRequestCode(Permission.SUB);
+ checkedAccess.addResourceAndPerm("topic1", Permission.PUB);
+ PlainAccessResource ownedAccess = new PlainAccessResource();
+ ownedAccess.setAccessKey("nonAdminUser");
+ ownedAccess.setAdmin(false);
+ ownedAccess.setDefaultTopicPerm(Permission.PUB);
+ try {
+ permissionChecker.check(checkedAccess, ownedAccess);
+ } catch (AclException e) {
+ Assert.fail("Should not throw any exception for default
permissions");
+ }
+ }
+
+ @Test(expected = AclException.class)
+ public void testCheck_withoutPermission_shouldThrowAclException() {
+ PlainAccessResource checkedAccess = new PlainAccessResource();
+ checkedAccess.setRequestCode(Permission.SUB);
+ checkedAccess.addResourceAndPerm("topic1", Permission.PUB);
+ PlainAccessResource ownedAccess = new PlainAccessResource();
+ ownedAccess.setAccessKey("nonAdminUser");
+ ownedAccess.setAdmin(false);
+ ownedAccess.setDefaultTopicPerm(Permission.SUB);
+ permissionChecker.check(checkedAccess, ownedAccess);
+ }
+
+}
