(rocketmq) branch develop updated: [ISSUE #8669] Fix crc 32 overflow when lmq

[jinrongtong]

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new ba8148f746 [ISSUE #8669] Fix crc 32 overflow when lmq
ba8148f746 is described below

commit ba8148f746a9ba6244de365485d7245cb52b90c4
Author: Dongyuan Pan <dongyuanp...@gmail.com>
AuthorDate: Wed Sep 11 17:06:40 2024 +0800

    [ISSUE #8669] Fix crc 32 overflow when lmq
---
 store/src/main/java/org/apache/rocketmq/store/CommitLog.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java 
b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
index f707d8fbd8..f34c6944c9 100644
--- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
+++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
@@ -1834,12 +1834,13 @@ public class CommitLog implements Swappable {
         private static final int END_FILE_MIN_BLANK_LENGTH = 4 + 4;
         // Store the message content
         private final ByteBuffer msgStoreItemMemory;
-        private final int crc32ReservedLength = enabledAppendPropCRC ? 
CommitLog.CRC32_RESERVED_LEN : 0;
+        private final int crc32ReservedLength;
         private final MessageStoreConfig messageStoreConfig;
 
         DefaultAppendMessageCallback(MessageStoreConfig messageStoreConfig) {
             this.msgStoreItemMemory = 
ByteBuffer.allocate(END_FILE_MIN_BLANK_LENGTH);
             this.messageStoreConfig = messageStoreConfig;
+            this.crc32ReservedLength = 
messageStoreConfig.isEnabledAppendPropCRC() ? CommitLog.CRC32_RESERVED_LEN : 0;
         }
 
         public AppendMessageResult handlePropertiesForLmqMsg(ByteBuffer 
preEncodeBuffer,