lizhanhui commented on code in PR #8600:
URL: https://github.com/apache/rocketmq/pull/8600#discussion_r1758834952
##########
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##########
@@ -164,12 +166,12 @@ private boolean shutdownInner() {
@Override
public void putMessagePositionInfoWrapper(DispatchRequest request) throws
RocksDBException {
- if (request == null || this.bufferDRList.size() >= BATCH_SIZE) {
- putMessagePosition();
- }
if (request != null) {
this.bufferDRList.add(request);
}
+ if (request == null || !enableBatchWriteKvCq ||
this.bufferDRList.size() >= BATCH_SIZE) {
Review Comment:
Batching without timeout is an obvious bug. Instead of add a configuration
to walk around this bug, please fix it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
