yuz10 commented on code in PR #1175:
URL:
https://github.com/apache/rocketmq-client-go/pull/1175#discussion_r1803108470
##########
producer/producer.go:
##########
@@ -403,7 +403,7 @@ func (p *defaultProducer) sendAsync(ctx context.Context,
msg *primitive.Message,
ctx, cancel := context.WithTimeout(ctx, p.options.SendMsgTimeout)
err := p.client.InvokeAsync(ctx, addr, p.buildSendRequest(mq, msg),
func(command *remote.RemotingCommand, err error) {
- cancel()
Review Comment:
Please explain what was fixed and how it was reproduced. Same code also in
trace.go, should that be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
