RongtongJin commented on code in PR #8842:
URL: https://github.com/apache/rocketmq/pull/8842#discussion_r1810013536
##########
store/src/main/java/org/apache/rocketmq/store/MessageExtEncoder.java:
##########
@@ -175,11 +176,11 @@ public PutMessageResult
encodeWithoutProperties(MessageExtBrokerInner msgInner)
public PutMessageResult encode(MessageExtBrokerInner msgInner) {
this.byteBuf.clear();
- if (CommitLog.isMultiDispatchMsg(messageStoreConfig, msgInner)) {
+ if (messageStoreConfig.isEnableLmq() &&
MixAll.topicAllowsLMQ(msgInner.getTopic())) {
Review Comment:
It should use `msgInner.needDispatchLMQ()` instead of
`MixAll.topicAllowsLMQ(msgInner.getTopic())`, otherwise non-lmq messages will
enter this branch and cause issues during writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
